Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript types to TreeView, TreeNode #13581

Closed
Tracked by #12513
tay1orjones opened this issue Apr 17, 2023 · 4 comments · Fixed by #17038
Closed
Tracked by #12513

Add TypeScript types to TreeView, TreeNode #13581

tay1orjones opened this issue Apr 17, 2023 · 4 comments · Fixed by #17038
Assignees
@Gururajj77
Labels
afrohacks See https://ibm.biz/afrohacks-hackathon area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐
Milestone
2024 Q3

Comments

@tay1orjones
Copy link
Member

No description provided.

@tay1orjones tay1orjones mentioned this issue Apr 17, 2023
Closed
@tay1orjones tay1orjones added status: help wanted 👐 role: dev 🤖 hacktoberfest See https://hacktoberfest.com/ area: typescript needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. labels Apr 17, 2023
cesardlinx added a commit to cesardlinx/carbon that referenced this issue Oct 4, 2023
@cesardlinx
refactor: add typescript types to TreeNode and TreeView (carbon-desig…
618190d 
…n-system#13581)
@cesardlinx cesardlinx mentioned this issue Oct 4, 2023
Closed
cesardlinx added a commit to cesardlinx/carbon that referenced this issue Oct 18, 2023
@cesardlinx
refactor: add typescript types to TreeNode and TreeView (carbon-desig…
0613935 
…n-system#13581)
@tay1orjones tay1orjones added the afrohacks See https://ibm.biz/afrohacks-hackathon label Oct 30, 2023
@danoro96 danoro96 mentioned this issue Feb 21, 2024
Closed
@imp-dance
Copy link
Contributor

imp-dance commented May 27, 2024 •
edited
Loading

I'll grab this one!

Didn't see a PR was already linked. I've got changes locally in case that PR dies.

@sstrubberg sstrubberg added this to the 2024 Q3 milestone Jul 9, 2024
@tay1orjones
Copy link
Member Author

@imp-dance Hey! That existing PR was put together before the TreeView controllable api and after resolving the merge conflicts many of the tests were failing. I just closed it to focus on making a new PR. If you still have those changes, we'd be up for collaborating on a new PR with you.

@imp-dance
Copy link
Contributor

@tay1orjones Cool, I'll sync up my branch and do some more work before I submit a PR. 👍

@imp-dance imp-dance mentioned this issue Jul 24, 2024
Merged
@imp-dance
Copy link
Contributor

@tay1orjones Got distracted with some other work for the last few days but finally got to take a second look at this. Set up a PR @ #17038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gururajj77 Gururajj77

Labels
afrohacks See https://ibm.biz/afrohacks-hackathon area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐
Projects
Design System
Status: ✅ Done
Initial TypeScript Support
Status: Done
Milestone
2024 Q3
4 participants
@imp-dance @tay1orjones @sstrubberg @Gururajj77