Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add icon section to adobe xd docs #2835

Merged
merged 4 commits into from
Mar 30, 2022
Merged

docs: add icon section to adobe xd docs #2835

merged 4 commits into from
Mar 30, 2022

Conversation

laurenmrice
Copy link
Member

  • Add an Icon section to the Adobe XD tab documentation.

New

  • Add Icon section
  • Add Icon content and resource card link to add the library.

@laurenmrice laurenmrice requested a review from thyhmdo March 30, 2022 15:17
@laurenmrice laurenmrice requested review from a team as code owners March 30, 2022 15:17
@laurenmrice laurenmrice requested review from abbeyhrt and dakahn March 30, 2022 15:17
@vercel
Copy link

vercel bot commented Mar 30, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/HA8CyAWzQbCtNr2tmvtgDXSZsRZP
✅ Preview: https://carbondesignsystem-git-fork-laurenm-b9ad39-carbon-design-system.vercel.app

abbeyhrt
abbeyhrt approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small note but otherwise looks good to me! :)

@laurenmrice @abbeyhrt
Update src/pages/designing/kits/adobe-xd.mdx
2f401ca 
Co-authored-by: Abbey Hart <abbeyhrt@gmail.com>
@laurenmrice laurenmrice requested a review from kingtraceyj March 30, 2022 21:45
kingtraceyj
kingtraceyj approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@kingtraceyj kingtraceyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to go!

@laurenmrice laurenmrice enabled auto-merge (squash) March 30, 2022 22:17
@laurenmrice laurenmrice merged commit 92c6eaf into carbon-design-system:v11 Mar 30, 2022
@laurenmrice laurenmrice deleted the adobe-xd-icon-content branch March 30, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingtraceyj kingtraceyj kingtraceyj approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@thyhmdo thyhmdo Awaiting requested review from thyhmdo

@dakahn dakahn Awaiting requested review from dakahn dakahn is a code owner automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurenmrice @abbeyhrt @kingtraceyj