Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logo Grid]: Add design modifications to the "Grid logo" component #8848

Closed
2 tasks done
proeung opened this issue May 16, 2022 · 0 comments · Fixed by #8905
Closed
2 tasks done

[Logo Grid]: Add design modifications to the "Grid logo" component #8848

proeung opened this issue May 16, 2022 · 0 comments · Fixed by #8905
Assignees
@andy-blum
Labels
adopter: AEM used when component or pattern will be used by this adopter feature flag Feature request A new adopter requested feature owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package priority: medium

Comments

@proeung
Copy link
Contributor

proeung commented May 16, 2022 •
edited by andy-blum
Loading

Engineering info:

The problem

Pattern - 16_9 (1)

The solution

  • Add an attribute/prop for logo-count
    • 3 column (default)
    • 4 column
  • Add an attribute/prop (eg. logo-ratio) for the different image ratios that we're supporting. The container of the logo item should be adjusted based on the defined ratio (see specs).

@oliviaflory @kennylam Feel free to add/adjust this solution area.

Application/website

AEM

Business priority

Medium Priority = upcoming release but is not pressing

What time frame would this ideally be needed by (if applicable)

We'd like to get these modifications in for the v.1.35.0 release.

Examples

No response

Code of Conduct
@proeung proeung added the Feature request A new adopter requested feature label May 16, 2022
@proeung proeung added feature flag package: web components Work necessary for the IBM.com Library web components package adopter: AEM used when component or pattern will be used by this adopter owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants labels May 16, 2022
@proeung proeung changed the title [Logo-Grid]: Add design modifications to the "Grid logo" component [Logo Grid]: Add design modifications to the "Grid logo" component May 16, 2022
@andy-blum andy-blum self-assigned this May 18, 2022
@andy-blum andy-blum mentioned this issue May 24, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #8905 Jun 6, 2022
kodiakhq bot pushed a commit that referenced this issue Jun 6, 2022
@andy-blum
feat(logo-grid): add logoCount and logoRatio props (#8905)
c519b06 
### Related Ticket(s)

Closes #8848

### Description

Adds `logoCount` and `logoRatio` props to `DDSLogoGrid`

`logoCount` takes an integer to use as a number of columns for the grid. The stylesheet will constrain that value to between 2 and 4, inclusively.

`logoRatio` takes a string matching the format `<integer><separator><integer>` and sets a custom CSS property in an inline style to use in logo-grid-item elements as an aspect ratio.

### Changelog

**New**

- Added `logoCount` and `logoRatio` props to `DDSLogoGrid`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy-blum andy-blum

Labels
adopter: AEM used when component or pattern will be used by this adopter feature flag Feature request A new adopter requested feature owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package priority: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(logo-grid): add logoCount and logoRatio props andy-blum/carbon-for-ibm-dotcom
8 participants
@kennylam @jeffchew @proeung @RichKummer @ljcarot @IgnacioBecerra @andy-blum @oliviaflory