Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dotcom-Shell with TOC]: Story Grid alignment issues #8486

Closed
2 tasks done
proeung opened this issue Mar 14, 2022 · 0 comments · Fixed by #8684
Closed
2 tasks done

[Dotcom-Shell with TOC]: Story Grid alignment issues #8486

proeung opened this issue Mar 14, 2022 · 0 comments · Fixed by #8684
Assignees
@andy-blum
Labels
bug Something isn't working dev Needs some dev work follow-up: innovation team owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants severity 4 Affects minor functionality, no workaround needed

Comments

@proeung
Copy link
Contributor

proeung commented Mar 14, 2022 •
edited
Loading

Engineering info:

Description

Note: All testing done on Chrome browser Version 98.0.4758.102 (Official Build) (x86_64)

Story grid alignment

I know we didn't have a design mock up for this story, but we do need to have everything aligned to the grid like the other Dotcom shell examples so we are demonstrating expected alignment to adopters.
Please let me know if the below examples are enough to go on!

Vertical TOC stories
Screen Shot 2022-03-11 at 4 57 48 PM

Expecting Prod example link
Screen Shot 2022-03-11 at 4 47 04 PM

Horizontal TOC Stories
Screen Shot 2022-03-11 at 4 47 49 PM

Expecting Prod example
Screen Shot 2022-03-11 at 4 46 09 PM

Component(s) impacted

Dotcom-Shell without shell (fallback utility)

Browser

Chrome

Carbon for IBM.com version

v.31.1

Severity

Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.

Application/website

AEM

Package

@carbon/ibmdotcom-web-components

CodeSandbox example

N/A

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct
@proeung proeung added bug Something isn't working dev Needs some dev work labels Mar 14, 2022
@proeung proeung added owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants follow-up: innovation team labels Mar 14, 2022
@proeung proeung mentioned this issue Mar 14, 2022
Merged
@proeung proeung added severity 3 Affects minor functionality, has a workaround severity 4 Affects minor functionality, no workaround needed and removed severity 3 Affects minor functionality, has a workaround labels Mar 14, 2022
@andy-blum andy-blum assigned andy-blum and unassigned mwanberg Apr 7, 2022
@andy-blum andy-blum mentioned this issue Apr 7, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #8684 Apr 18, 2022
kodiakhq bot pushed a commit that referenced this issue Apr 18, 2022
@andy-blum
feat(sticky header utility): update storybook story & remove old dotc…
136a610 
…om-shell code (#8684)

### Related Ticket(s)

Closes #8486 #8472

### Description

This PR is a followup top #8434 in which the dotcom-shell's scroll handling was mimicked in a utility class.

This PR aims to cleanup the storybook integration and removes now unnecessary code from the dotcom-shell-composite class.

### Changelog

**Changed**

- Updated storybook story for new dotcom-shell scrolling utility

**Removed**

- Scroll handling logic removed from the dotcom-shell component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy-blum andy-blum

Labels
bug Something isn't working dev Needs some dev work follow-up: innovation team owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants severity 4 Affects minor functionality, no workaround needed
Projects
None yet
Milestone
No milestone
8 participants
@mwanberg @jeffchew @proeung @RichKummer @ljcarot @IgnacioBecerra @andy-blum @oliviaflory