Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues upgrading to Carbon for IBM.com v1.18.0 #5867

Closed
jeffchew opened this issue Apr 22, 2021 · 2 comments
Closed

Issues upgrading to Carbon for IBM.com v1.18.0 #5867

jeffchew opened this issue Apr 22, 2021 · 2 comments
Assignees
@jeffchew
Labels
adopter support bug Something isn't working dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package package: styles Work necessary for the Carbon for IBM.com styles package package: web components Work necessary for the IBM.com Library web components package severity 2 Affects major functionality, has a workaround
Milestone
Sprint 21-08

Comments

@jeffchew
Copy link
Member

Detailed description

Describe in detail the issue you're having.

From a couple of adopters:

We are getting build issue w.r.t ibmdotcom-styles package.

image

anyone else getting this issue when trying to upgrade to v1.18.0?

image

warning "@carbon/ibmdotcom-react@1.18.0" has incorrect peer dependency "carbon-components@10.32.1".
warning "@carbon/ibmdotcom-web-components > carbon-web-components@1.12.0" has incorrect peer dependency "carbon-components@~10.30.0".

➜  think-2021-nextjs git:(master) ✗ yarn install
Couldn't find any versions for "carbon-components-react" that matches "^7.33.1"
? Please choose a version of "carbon-components-react" from this list: (Use arrow keys)
❯ 7.33.0
  7.33.0-rc.0

Is this a feature request (new component, new icon), a bug, or a general
issue?

Bug

Is this issue related to a specific component?

Application install level

What did you expect to happen? What happened instead? What would you like to
see changed?

No issues upgrading to latest Carbon for IBM.com

What version of Carbon for IBM.com are you using?

v1.18.0
@jeffchew jeffchew added bug Something isn't working package: react Work necessary for the Carbon for IBM.com react components package severity 2 Affects major functionality, has a workaround dev Needs some dev work package: styles Work necessary for the Carbon for IBM.com styles package adopter support package: web components Work necessary for the IBM.com Library web components package labels Apr 22, 2021
@jeffchew jeffchew added this to the Sprint 21-08 milestone Apr 22, 2021
@jeffchew jeffchew self-assigned this Apr 22, 2021
@jeffchew jeffchew mentioned this issue Apr 22, 2021
Merged
kodiakhq bot pushed a commit that referenced this issue Apr 22, 2021
@jeffchew
fix(dependencies): changed @carbon/telemetry to be a dependency (#5871)
5a1e23b 
### Related Ticket(s)

#5867 

### Description

Adopters were providing feedback that the `carbon-telemetry` command was
 not found, which is due to the case that @carbon/telemetry was only a
 dev dependency. This change moves it to the dependencies list.

 In addition, the upstream Carbon dependencies that were originally
 identified as peer dependencies are now optional dependencies.

### Changelog

**Changed**

- `@carbon/telemetry` now a dependency for public packages
- Moved upstream Carbon peer dependencies to optional dependencies
@RobertaJHahn
Copy link

@jeffchew Can this issue be closed? There is a merged PR.

@jeffchew
Copy link
Member Author

@RobertaJHahn yes. And why are you working on a Sunday?

@jeffchew jeffchew mentioned this issue Apr 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffchew jeffchew

Labels
adopter support bug Something isn't working dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package package: styles Work necessary for the Carbon for IBM.com styles package package: web components Work necessary for the IBM.com Library web components package severity 2 Affects major functionality, has a workaround
Projects
None yet
Milestone
Sprint 21-08
Development

No branches or pull requests
2 participants
@jeffchew @RobertaJHahn