Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web components: Masthead #2861

Closed
6 tasks done
asudoh opened this issue Jun 23, 2020 · 0 comments
Closed
6 tasks done

Web components: Masthead #2861

asudoh opened this issue Jun 23, 2020 · 0 comments
Assignees
@asudoh
Labels
dev Needs some dev work Feature request A new adopter requested feature package: web components Work necessary for the IBM.com Library web components package sprint demo
Milestone
Sprint 20-14

Comments

@asudoh
Copy link
Contributor

asudoh commented Jun 23, 2020 •
edited by RobertaJHahn
Loading

The problem

Need a masthead that we can created in a sophisticated way, and works with all JavaScript frameworks.

The solution

Create a masthead with Shadow DOM and Custom Elements standards.

Additional Information

Acceptance Criteria

  • Creation of the masthead component in web-components
  • Include README for adopters
  • Feature parity with the React version
  • Include story variations
  • Include data-autoid attributes, same as the React masthead and include in README
  • Post a message in the Prod QA testing issue tagging Praveen and Chetan when ready to test
@asudoh asudoh added the Feature request A new adopter requested feature label Jun 23, 2020
@asudoh asudoh self-assigned this Jun 23, 2020
@jeffchew jeffchew changed the title Custom Elements: Masthead Web components: Masthead Jun 24, 2020
@jeffchew jeffchew added the package: web components Work necessary for the IBM.com Library web components package label Jun 24, 2020
asudoh added a commit to asudoh/ibm-dotcom-library that referenced this issue Jun 30, 2020
@asudoh
feat(masthead): introduce web components
5bb2898 
This change introduces Web Components version of masthead (L0).

This change also introduces:

* `lit-html` version of the icons defined in
  `@carbon/ibmdotcom-styles`. To do this, needed to hoist
  `carbon-components`/`carbon-custom-elements` dependencies given
  `lit-html` version of the icons that is create on-the-fly in
  development time isn't tied to `packages/web-components`
* Several mix-ins for masthead style rules. This required given they
  are under deeply nested selectors that are hard to define custom
  elements selectors alongside
* `lit-staged` support for TypeScript files

Refs carbon-design-system#2861.
@asudoh asudoh mentioned this issue Jun 30, 2020
Merged
@RobertaJHahn RobertaJHahn added this to the Sprint 20-13 milestone Jun 30, 2020
@RobertaJHahn RobertaJHahn mentioned this issue Jul 1, 2020
Closed
@RobertaJHahn RobertaJHahn mentioned this issue Jul 6, 2020
Closed
5 tasks
asudoh added a commit that referenced this issue Jul 6, 2020
@asudoh
feat(masthead): introduce web components (#2960)
3e3c3c5 
This change introduces Web Components version of masthead (L0).

This change also introduces:

* `lit-html` version of the icons defined in
  `@carbon/ibmdotcom-styles`. To do this, needed to hoist
  `carbon-components`/`carbon-custom-elements` dependencies given
  `lit-html` version of the icons that is create on-the-fly in
  development time isn't tied to `packages/web-components`
* Several mix-ins for masthead style rules. This required given they
  are under deeply nested selectors that are hard to define custom
  elements selectors alongside
* `lit-staged` support for TypeScript files

Refs #2861.
@RobertaJHahn RobertaJHahn added the dev Needs some dev work label Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asudoh asudoh

Labels
dev Needs some dev work Feature request A new adopter requested feature package: web components Work necessary for the IBM.com Library web components package sprint demo
Projects
None yet
Milestone
Sprint 20-14
Development

No branches or pull requests
3 participants
@asudoh @jeffchew @RobertaJHahn