carbon-components 10.9.3 introduces breaking change to masthead

[photodow]

Detailed description

It was just brought to my attention by @dfrsol that we want to be careful before updating to Carbon's latest or anything past 10.9.3. It looks like they introduced a breaking change based on how we're modifying our masthead.

The removed the role selectors form masthead.

carbon-design-system/carbon@d9935c3#diff-f8c1a41d640bb6e6c4213525998e936e

We're still using these selectors on the masthead

a.#{$prefix}--header__menu-item[role='menuitem'] {

https://github.com/carbon-design-system/ibm-dotcom-library/blob/master/packages/styles/scss/components/masthead/_masthead-l1.scss#L145

[jeffchew]

@kennylam is this something we should worry about at the moment? The comment above shows for L1, which is still behind an experimental flag.

cc: @photodow @RobertaJHahn

[kennylam]

@kennylam is this something we should worry about at the moment? The comment above shows for L1, which is still behind an experimental flag.

@jeffchew let me take a look at this, but I think it's basically the one @andysherman2121 fixed two sprints ago.

[kennylam]

@jeffchew @RobertaJHahn @photodow confirmed that this is not currently affecting us. We are still on carbon-components@10.9.0. But we will need to update our Masthead styles eventually, as updating to their latest package will completely break the masthead.

Suggest closing this and creating a new story to audit all components with carbon-components as a dependency and how they will be affected if/when we update to the latest package.

[RobertaJHahn]

Created an epic and issue to manage the work required for a carbon-components upgrade. epic (#1876), issue (#1878). Closing this issue.

cc: @kennylam