Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding hideCloseButton prop to cv-inline-notification #1233

Conversation

luizamendes
Copy link
Contributor

@luizamendes luizamendes commented Jul 30, 2021

Closes #1210

## What did you do?

  • Added hideCloseButton prop to the Inline Notification component
  • Added snapshot tests for the case of this prop being true
  • Updated storybook page

## Why did you do it?

  • This prop was missing from the component
  • There was an open issue about it

How have you tested it?

  • Checked if the storybook was updated and toggled the property on and off to check if the results were as expected
  • Wrote a snapshot test passing the new prop as true

Were docs updated if needed?

  • N/A
  • No
  • Yes

@netlify
Copy link

netlify bot commented Jul 30, 2021

✔️ Deploy Preview for carbon-components-vue ready!

🔨 Explore the source changes: f39f571

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-vue/deploys/6116a4103e4bb8000747750b

😎 Browse the preview: https://deploy-preview-1233--carbon-components-vue.netlify.app

@lee-chase lee-chase merged commit fd41a30 into carbon-design-system:main Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cv-inline-notification is missing the "hideCloseButton" property
2 participants