Skip to content

Commit

Permalink
fix: update test to match aria and v-model changes
Browse files Browse the repository at this point in the history
  • Loading branch information
davidnixon committed Nov 10, 2023
1 parent 4d259ba commit ccba212
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions src/components/CvDropdown/__tests__/CvDropdown.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ describe('CvDropdown', () => {
placeholder: placeholder,
size: 'md',
up: false,
value: undefined,
modelValue: undefined,
warningMessage: '',
light: false,
},
Expand All @@ -88,7 +88,7 @@ describe('CvDropdown', () => {

let mysteriousLabels = await result.findAllByText('The Armorer');
expect(mysteriousLabels.length).toBe(1);
await result.rerender({ value: 'mysterious' });
await result.rerender({ modelValue: 'mysterious' });
mysteriousLabels = await result.findAllByText('The Armorer');
expect(mysteriousLabels.length).toBe(2);

Expand Down
8 changes: 4 additions & 4 deletions src/components/CvMultiSelect/__tests__/CvMultiSelect.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ describe('CvMultiSelect', () => {
const result = render(CvMultiSelect, {
props: {
options: pkdOptions,
value: pkdValues.slice(3, 6), // select 3 items
modelValue: pkdValues.slice(3, 6), // select 3 items
},
attrs: {
class: 'ABC-class-123',
Expand All @@ -63,7 +63,7 @@ describe('CvMultiSelect', () => {
const result = render(CvMultiSelect, {
props: {
options: pkdOptions,
value: initiallySelected,
modelValue: initiallySelected,
},
attrs: {
class: 'ABC-class-123',
Expand Down Expand Up @@ -246,8 +246,8 @@ describe('CvMultiSelect', () => {
const options = {
props: {
options: pkdOptions,
value: myValue,
'onUpdate:value': e => {
modelValue: myValue,
'onUpdate:modelValue': e => {
myValue = e;
},
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ exports[`CvTabs CvTabs - test slotted tab buttons to match snapshot 1`] = `
</svg></button>
<!--v-if-->
<ul class="bx--tabs--scrollable__nav" role="tablist">
<li class="cv-tabs-button bx--tabs--scrollable__nav-item bx--tabs__nav-item--selected bx--tabs--scrollable__nav-item--selected" role="presentation"><button id="tab-1-link" class="bx--tabs--scrollable__nav-link" role="tab" aria-controls="tab-1" aria-disabled="false" aria-selected="true" tabindex="0" type="button">Hello <strong style="color: red;">(*)</strong></button></li>
<li class="cv-tabs-button bx--tabs--scrollable__nav-item" role="presentation"><button id="tab-2-link" class="bx--tabs--scrollable__nav-link" role="tab" aria-controls="tab-2" aria-disabled="false" aria-selected="false" tabindex="-1" type="button">Origin<strong style="color: orange;">(!)</strong></button></li>
<li class="cv-tabs-button bx--tabs--scrollable__nav-item" role="presentation"><button id="tab-3-link" class="bx--tabs--scrollable__nav-link" role="tab" aria-controls="tab-3" aria-disabled="false" aria-selected="false" tabindex="-1" type="button">Tab 3 label</button></li>
<li class="cv-tabs-button bx--tabs--scrollable__nav-item bx--tabs__nav-item--selected bx--tabs--scrollable__nav-item--selected" role="presentation"><button id="tab-1-link" class="bx--tabs--scrollable__nav-link" role="tab" aria-controls="tab-1" aria-selected="true" tabindex="0" type="button">Hello <strong style="color: red;">(*)</strong></button></li>
<li class="cv-tabs-button bx--tabs--scrollable__nav-item" role="presentation"><button id="tab-2-link" class="bx--tabs--scrollable__nav-link" role="tab" aria-controls="tab-2" aria-selected="false" tabindex="-1" type="button">Origin<strong style="color: orange;">(!)</strong></button></li>
<li class="cv-tabs-button bx--tabs--scrollable__nav-item" role="presentation"><button id="tab-3-link" class="bx--tabs--scrollable__nav-link" role="tab" aria-controls="tab-3" aria-selected="false" tabindex="-1" type="button">Tab 3 label</button></li>
</ul>
<!--v-if--><button aria-hidden="true" aria-label="scroll right" class="bx--tab--overflow-nav-button--hidden" tabindex="-1" type="button"><svg focusable="false" preserveAspectRatio="xMidYMid meet" xmlns="http://www.w3.org/2000/svg" fill="currentColor" width="16" height="16" viewBox="0 0 16 16" aria-hidden="true">
<path d="M11 8L6 13 5.3 12.3 9.6 8 5.3 3.7 6 3z"></path>
Expand Down

0 comments on commit ccba212

Please sign in to comment.