fix: use null instead of false to remove aria-disabled

carbon-design-system · Nov 6, 2023 · a071aae · a071aae
1 parent 641b828
commit a071aae
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/components/CvComboBox/CvComboBox.vue b/src/components/CvComboBox/CvComboBox.vue
@@ -59,7 +59,7 @@
           :aria-controls="cvId"
           aria-autocomplete="list"
           role="combobox"
-          :aria-disabled="disabled"
+          :aria-disabled="disabled || null"
           :aria-expanded="open ? 'true' : 'false'"
           autocomplete="off"
           :disabled="disabled"

diff --git a/src/components/CvDropdown/CvDropdown.vue b/src/components/CvDropdown/CvDropdown.vue
@@ -73,7 +73,7 @@
         <button
           ref="button"
           :aria-controls="`${uid}-menu`"
-          :aria-disabled="disabled"
+          :aria-disabled="disabled || null"
           :aria-expanded="open ? 'true' : 'false'"
           :aria-labelledby="ariaLabeledBy"
           :class="`${carbonPrefix}--list-box__field`"
@@ -129,7 +129,7 @@
       </div>
       <div
         v-else-if="data.isHelper"
-        :aria-disabled="disabled"
+        :aria-disabled="disabled || null"
         :class="[
           `${carbonPrefix}--form__helper-text`,
           { [`${carbonPrefix}--form__helper-text--disabled`]: disabled },

diff --git a/src/components/CvMultiSelect/CvMultiSelect.vue b/src/components/CvMultiSelect/CvMultiSelect.vue
@@ -65,7 +65,7 @@
         ref="elButton"
         type="button"
         :class="`${carbonPrefix}--list-box__field`"
-        :aria-disabled="disabled"
+        :aria-disabled="disabled || null"
         aria-haspopup="listbox"
         :aria-expanded="data.open ? 'true' : 'false'"
         :aria-owns="uid"

diff --git a/src/components/CvProgress/CvProgressStep.vue b/src/components/CvProgress/CvProgressStep.vue
@@ -6,7 +6,7 @@
       `cv-progress-step ${carbonPrefix}--progress-step`,
       `${carbonPrefix}--progress-step--${internalState}`,
     ]"
-    :aria-disabled="disabled"
+    :aria-disabled="disabled || null"
   >
     <button
       type="button"

diff --git a/src/components/CvTabs/CvTabs.vue b/src/components/CvTabs/CvTabs.vue
@@ -70,7 +70,7 @@
             :class="`${carbonPrefix}--tabs--scrollable__nav-link`"
             role="tab"
             :aria-controls="tab.uid"
-            :aria-disabled="disabledTabs.has(tab.uid)"
+            :aria-disabled="disabledTabs.has(tab.uid) || null"
             :aria-selected="selectedId === tab.uid"
             :tabindex="selectedId === tab.uid ? 0 : -1"
             type="button"