Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): remove cheerio, use native DOM methods for tooltip manipulation #1726

Merged
merged 4 commits into from
Oct 28, 2020

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Oct 26, 2020

Closes #1707

Summary

Change List (commits, features, bugs, etc)

  • remove cheerio and other unused rollup plugins
  • remove rollup-plugin-node-builtins from rollup config/build
  • refactor previous usages of cheerio to use built in DOM methods and apis
  • abstract DOMParser into helper function and cover with tests

Acceptance Test (how to verify the PR)

@netlify
Copy link

netlify bot commented Oct 26, 2020

Deploy preview for carbon-addons-iot-react ready!

Built with commit dd2f461

https://deploy-preview-1726--carbon-addons-iot-react.netlify.app

@kodiakhq kodiakhq bot merged commit ce81cbd into next Oct 28, 2020
@kodiakhq kodiakhq bot deleted the 1707-fix-build-refactor-chart-tooltips branch October 28, 2020 16:17
@tay1orjones
Copy link
Member Author

🎉 This PR is included in version 2.140.0-next.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tay1orjones
Copy link
Member Author

🎉 This PR is included in version 2.140.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[repo] umd build is broken, stackblitz fails to load
3 participants