feat(table): enable single nested hierarchy styling #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstone2423
requested review from
blechner,
bryancboyd,
cgirani,
davidicus,
jessieyan,
JoelArmendariz,
leetosc,
scottdickerson,
stuckless,
tay1orjones and
tomklapiscak
as code owners
|
Deploy preview for carbon-addons-iot-react ready! Built with commit 1b22d2b https://deploy-preview-1609--carbon-addons-iot-react.netlify.app |
bjornalm
approved these changes
Sep 16, 2020
added 2 commits
September 17, 2020 10:06
…s-iot-react into table-hierarchy
sstone2423
added
status: one more review 👀
status: ready for code owner's review
and removed
status: WIP 👩💻
labels
tay1orjones
approved these changes
Sep 18, 2020
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for code owner's review
labels
…s-iot-react into table-hierarchy
|
🎉 This PR is included in version 2.122.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1602
Closes #1600
Summary
hasSingleNestedHierarchyas an option that will disable the gray offset if enabledRelated internal Monitor design: https://ibm.invisionapp.com/share/KWO0FZ5BHQ9#/screens/319695909
Change List (commits, features, bugs, etc)
hasSingleNestedHierarchypropAcceptance Test (how to verify the PR)
Regression Test (how to make sure I didn't break things)
Go to ?path=/story/watson-iot-table--stateful-example-with-row-nesting-and-fixed-columns
Go to table resize AND fixed column stories to ensure that the padding still looks correct in the select all checkbox in the table head AND the offset still works correctly with those (if they include nested rows)