Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes and improvements to FFmpeg autocompletion #2472

Merged
merged 4 commits into from
Aug 14, 2024
Merged

fixes and improvements to FFmpeg autocompletion #2472

merged 4 commits into from
Aug 14, 2024

Conversation

jopejoe1
Copy link
Contributor

Things done in this pr:

  • fixes format completion, not returning anything
  • filter device type for sink and source
  • filter codec type
  • on codec completion also fill in encoders and copy
  • handle subtitle codec
  • autocomplete all codecs if codec is not specified

@rsteube rsteube merged commit 5b4c1a6 into carapace-sh:master Aug 14, 2024
3 checks passed
@rsteube
Copy link
Member

rsteube commented Aug 14, 2024

Ok, hope I got all the important bits in. Just open another issue/pr if I botched something.

@jopejoe1 jopejoe1 deleted the ffmpeg-codecs branch September 19, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille left review comments

@rsteube rsteube rsteube left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jopejoe1 @rsteube @ccoVeille