Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPI E2E Test #262

Merged
merged 65 commits into from
Oct 20, 2022
Merged
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
11a6034
Grpc fiber integration with UPI in router (#238)
leonlnj Sep 26, 2022
a55497b
[UPI] Api Server (#255)
leonlnj Oct 11, 2022
116ffe7
UPI Traffic Splitting (#259)
pradithya Oct 13, 2022
2998650
Deploy 3 upi echo server in end to end test
Oct 13, 2022
8fb8887
Update incorrect test setup
Oct 13, 2022
f575bae
Merge branch 'grpc_upi' of github.com:caraml-dev/turing into e2e_traf…
Oct 13, 2022
5437dac
Update python sdk
Oct 13, 2022
00964e7
Add test helper
Oct 13, 2022
15277ad
Update sdk
Oct 13, 2022
ac8bc4c
Simplify model name
Oct 13, 2022
8fac462
Add test for traffic splitting
Oct 13, 2022
4201df1
Include in test suite
Oct 13, 2022
11bf117
Reduce mock server cpu request
Oct 14, 2022
56fb433
Temporary comment passing tests
Oct 14, 2022
7e32be8
Add logging
Oct 14, 2022
608285b
Add debugging logs
Oct 14, 2022
a0cce2c
Rename router for upi traffic splitting e2e test
Oct 14, 2022
5a193db
Print properly
Oct 14, 2022
456dd21
Improve assertion in the withDeployedRouter
Oct 14, 2022
454de61
Reduce cpu request for all e2e test
Oct 14, 2022
36f25e7
Add default_route_id
Oct 14, 2022
aed55a3
Merge branch 'grpc_upi' of github.com:caraml-dev/turing into e2e_traf…
Oct 14, 2022
a86e740
Move response logging before status code assertion
Oct 14, 2022
8a29545
Add e2e test for standard ensembler
Oct 14, 2022
f4b76fe
Rename router name
Oct 14, 2022
24993f9
Associate control with all traffic rule
Oct 14, 2022
d032edc
Fix incorrect router file name
Oct 14, 2022
c1f849b
Temporary disable sdk e2e test
Oct 14, 2022
584dfac
Temporary exclude sdk test
Oct 17, 2022
84f6650
Use require instead of assert
Oct 17, 2022
4254919
Change ordering of waiting for component ready
Oct 17, 2022
c8ca251
Shorten router name
Oct 17, 2022
3f4a81b
Exclude tests
Oct 17, 2022
d7fda9c
Add debugging code
Oct 17, 2022
83930ce
Add pod log
Oct 17, 2022
6a5b8c3
Change protocol
Oct 17, 2022
6399cc0
Change protobuf equality check
Oct 17, 2022
5dd0eee
Add more detailed error info
Oct 17, 2022
71214e0
Try fiber without cloning
Oct 17, 2022
ee454f1
Replace deprecated library
Oct 17, 2022
5c82b41
Fix debugging code
Oct 17, 2022
9b1866a
Read configmap
Oct 17, 2022
5a89e81
Print type
Oct 17, 2022
13d5399
Try printing configmap
Oct 17, 2022
5ece3ec
Update fiber
Oct 18, 2022
636401e
Update end to end test for traffic rule
Oct 18, 2022
d539945
Fix unit tests in router
Oct 18, 2022
322f4d0
Update go.mod in turing api
Oct 18, 2022
f8b84f7
Remove mockserver-b deployment since it's not used
Oct 18, 2022
263d140
Add end to end test for sdk
Oct 18, 2022
07bf5b2
Reenable all end to end test
Oct 18, 2022
d4ca5da
Reduce cpu resource request to improve e2e test stability
Oct 18, 2022
e6f57de
Remove debugging code
Oct 18, 2022
69e5300
Fix formatting in README.md
Oct 18, 2022
708d230
Add debuging code for sdk e2e test
Oct 18, 2022
7f9f585
Change test name
Oct 18, 2022
20c6cd7
Include UPI test
Oct 18, 2022
a2df328
Change incorrect comment
Oct 19, 2022
fe7fbb7
Increase cpu request to 100m
Oct 19, 2022
5facbd2
Add kubectl top nodes before each e2e test group
Oct 19, 2022
2d405ed
Remove kubectl top nodes since it's not supported
Oct 19, 2022
2d7014c
Increase enricher and ensembler cpu request
Oct 19, 2022
58675ae
Remove misleading comment
Oct 20, 2022
a78dd17
Update test comment
Oct 20, 2022
9643dc3
Update api spec comments and generated code
Oct 20, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update python sdk
Pradithya Aria committed Oct 13, 2022
commit 5437dac27b3b657da36e94114c04a7acd7ca6e0d
2 changes: 1 addition & 1 deletion sdk/turing/generated/model/traffic_rule_condition.py
Original file line number Diff line number Diff line change
@@ -115,7 +115,7 @@ def __init__(self, field_source, field, values, *args, **kwargs): # noqa: E501
Args:
field_source (FieldSource):
field (str): If `field_source` is `header`, then `field` should contain the name of the request header, otherwise, if `field_source` is `payload`, then `field` should be a valid json path
field (str): For HTTP_JSON protocol, the valid `field_source` are `header` and `payload`. Whereas, for UPIV1 protocol the valid `field_source` are `header` and `prediction_context` If `field_source` is `header`, then `field` should contain the name of the request header, otherwise, if `field_source` is `payload`, then `field` should be a valid json path. If `field_source` is `header`, then `field` should contain the name of the request header, otherwise, if `field_source` is `prediction_context`, then `field` should contains variable name.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If field_source is header, then field should contain the name of the request header

I think this part of the comment is repeated. From the way the description is written here, it's not clear that the lines 2 and 3 correspond to different protocols and I'm not sure it's important to distinguish. Shall we simply remove the duplicated line?

      description: >
        For HTTP_JSON protocol, the valid `field_source` are `header` and `payload`. Whereas, for UPIV1 protocol the valid `field_source` are `header` and `prediction_context`
        If `field_source` is `header`, then `field` should contain the name of the request header. If `field_source` is `payload`, then `field` should be a valid json path. If `field_source` is `prediction_context`, then `field` should contains variable name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, rephrased the documentation.

values ([str]):
Keyword Args:
1 change: 1 addition & 0 deletions sdk/turing/router/config/traffic_rule.py
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@
class FieldSource(Enum):
HEADER = "header"
PAYLOAD = "payload"
PREDICTION_CONTEXT = "prediction_context"

def to_open_api(self) -> OpenApiModel:
return turing.generated.models.FieldSource(self.value)