-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ci teardown to cluster init #150
Update ci teardown to cluster init #150
Conversation
@leonlnj I understand that this is a draft PR, but in case you haven't considered it yet, then my early feedback would be to share common cluster setup steps between gojek/turing already contains one custom action here: https://github.com/gojek/turing/blob/main/.github/actions/release-rules/action.yaml |
ah thanks, i was still looking around on how to extract common code, that helps! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a suggestion on how to make cluster-init
workflow aligned with the main Turing CI workflow (to structure it as build -> test-e2e -> publish
). The rest looks good!
…init. change turing and cluster init workflow to use the new action
ef5c896
to
7d2bbd0
Compare
Summary
Refactor existing Turing CI workflow, to remove tear down of cluster and do it as an e2e test part of cluster-init workflow.
Modification
.github/actions/cluster-init/action.yaml
- New github action to be called by both Turing and cluster-init workflow to init the cluster. It will contain inputs to optionally build an image or to use an built jar.The steps involved are:
.github/workflows/cluster-init.yaml
- Updated to include an e2e test.Steps
cluster-init
github action.github/workflows/turing.yaml
- Extracted installation of cluster as github action and to call the action instead. Removed tearing down of cluster.