Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more granular config for model observability during deployment #619

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

tiopramayudi
Copy link
Collaborator

Description

Adding model_observability configuration that contains:

  • Enable -> Whether the model observability is enabled or not
  • Ground Truth Source -> The source for ground truth which later on will be use to ingest ground truth
  • Ground Truth Job -> The Job configuration to ingest ground truth
  • Prediction Log Ingestion Resource -> Resource configuration for observability publisher worker, currently we use default value that is set on platform level

Modifications

  • Modify swagger
  • Regenerate python client from modified swagger spec
  • Modify model_observability model
  • Update deployment of observability publisher worker
  • Update merlin sdk so user can supply model_observability config during deployment

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes


@tiopramayudi tiopramayudi added the enhancement New feature or request label Nov 22, 2024
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the extensive changes @tiopramayudi ! Everything looks good as it is; I only just left a couple of tiny questions but feel free to merge this any time you're ready 🚀

…bled but the associated model is not support observability
@tiopramayudi tiopramayudi merged commit 95d2e48 into main Dec 5, 2024
33 checks passed
@tiopramayudi tiopramayudi deleted the model-observability branch December 5, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants