Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Fix #2079: Add missing 1 immediate to rcl #2329

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Apr 24, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Closes #2079. I kept the disassembly the same, because it is the one currently used in LLVM.

Test plan

Add to issues.cs

./cstool -d x32 0xd1,0x10
 0  d1 10                                            rcl	dword ptr [eax]
	ID: 615 (rcl)
	Prefix:0x00 0x00 0x00 0x00 
	Opcode:0xd1 0x00 0x00 0x00 
	rex: 0x0
	addr_size: 4
	modrm: 0x10
	disp: 0x0
	sib: 0x0
	imm_count: 1
		imms[1]: 0x1
	op_count: 2
		operands[0].type: MEM
			operands[0].mem.base: REG = eax
		operands[0].size: 4
		operands[0].access: READ
		operands[1].type: IMM = 0x1
		operands[1].size: 0
		operands[1].access: READ
	Registers read: eax
	Registers modified: eflags
	EFLAGS: MOD_CF UNDEF_OF

Closing issues

closes #2079

@Rot127 Rot127 added the X86 Arch label Apr 24, 2024
@Rot127 Rot127 changed the title Add missing 1 immediate to rcl [v5] Fix #2079: Add missing 1 immediate to rcl Apr 24, 2024
@Rot127 Rot127 added this to the v5.0.2 milestone Apr 24, 2024
@kabeor kabeor merged commit 52b23b7 into capstone-engine:v5 Apr 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X86 Arch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants