Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBDIRARCH does not propagate to Makefile #2214

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

YaSuenag
Copy link
Contributor

I did not see lib64 under capstone directory when I installed it via make.sh as following:

$ PREFIX=/tmp/capstone ./make.sh install
  :
<snip>
  :
$ ls /tmp/capstone
bin  include  lib

We could not use pkg-config to detect capstone directories because libdir in capstone.pc points to lib64:

$ cat /tmp/capstone/lib/pkgconfig/capstone.pc
Name: capstone
Description: Capstone disassembly engine
Version: 5.0.0
libdir=/tmp/capstone/lib64
includedir=/tmp/capstone/include/capstone
archive=${libdir}/libcapstone.a
Libs: -L${libdir} -lcapstone
Libs.private: -L${libdir} -l:libcapstone.a
Cflags: -I${includedir}
archs=arm aarch64 m68k mips powerpc sparc systemz x86 xcore tms320c64x m680x evm riscv mos65xx wasm bpf sh tricore

make.sh would kick make with LIBDIRARCH=lib64 if /usr/lib64 exists, but it does not propagate to make install. We can see same problem in uninstall(). We need to export or set it to each commands.

@kabeor
Copy link
Member

kabeor commented Jan 3, 2024

LGTM, thank you for your contribution!

@kabeor kabeor merged commit b9c260e into capstone-engine:next Jan 3, 2024
11 checks passed
@YaSuenag YaSuenag deleted the pr/make-sh branch January 3, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants