add support for aarch64 distributions #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @aquynh |
|
I'm not sure why I'm tagged for this PR. I'm maintaining the m68k backend. |
Apologies for that. Removed. |
|
Btw, I verified this builds correctly on a Raspberry Pi 3 and 4 (64-bit). |
|
Can you please create a new PR on libcapstone? |
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
manylinux1does not seem to support aarch64 architectures (see the manylinux README). I'm getting this error when trying to install the wheel withpip:According to PEP 599 it seems like
manylinux2014is what should be used instead.Here are logs from our failing build (in NixOS): https://hydra.nixos.org/build/134963890/nixlog/1/tail