invoke from_buffer only for writeable interfaces

capstone-engine · Nov 12, 2021 · 684187a · 684187a
1 parent d59c50f
commit 684187a
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/bindings/python/capstone/__init__.py b/bindings/python/capstone/__init__.py
@@ -1099,8 +1099,9 @@ def disasm(self, code, offset, count=0):
             print(code)'''
         # Pass a bytearray by reference
         size = len(code)
-        if isinstance(code, (bytearray, memoryview)):
-            code = ctypes.byref(ctypes.c_char.from_buffer(code))
+        view = memoryview(code)
+        if not view.readonly:
+            code = ctypes.byref(ctypes.c_char.from_buffer(view))
         res = _cs.cs_disasm(self.csh, code, size, offset, count, ctypes.byref(all_insn))
         if res > 0:
             try:
@@ -1127,8 +1128,9 @@ def disasm_lite(self, code, offset, count=0):
         all_insn = ctypes.POINTER(_cs_insn)()
         size = len(code)
         # Pass a bytearray by reference
-        if isinstance(code, (bytearray, memoryview) ):
-            code = ctypes.byref(ctypes.c_char.from_buffer(code))
+        view = memoryview(code)
+        if not view.readonly:
+            code = ctypes.byref(ctypes.c_char.from_buffer(view))
         res = _cs.cs_disasm(self.csh, code, size, offset, count, ctypes.byref(all_insn))
         if res > 0:
             try: