Fix CharsetMatches type error #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junholee6a
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
from_bytes() has return type CharsetMatches, and CharsetMatches.best() has return type CharsetMatch|None. Notice that CharsetMatches and CharsetMatch are distinct. Also, CharsetMatches.first() is equivalent to calling CharsetMatches.best(). Fixes the code trying to call CharsetMatch.first(), which is undefined. This in turn fixes mypy type errors. Note, the previous code should've thrown an error but didn't, so this portion of the code is probably not covered by unit tests. It wouldn't be easy to write a test for this since this part of the code is only reached if the first encoding detector fails.
junholee6a
force-pushed
the
fix-charsetmatch-selection
branch
from
06bdfa5 to
4f53fc1
Compare
JGSweets
approved these changes
May 9, 2023
taylorfturner
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_bytes()has return typeCharsetMatches, andCharsetMatches.best()has return typeCharsetMatch|None. Notice thatCharsetMatchesandCharsetMatchare distinct. Also,CharsetMatches.first()is equivalent to callingCharsetMatches.best(). Fixes the code trying to callCharsetMatch.first(), which is undefined. This also fixes the following mypy type errors (from #811 (comment)):Note, the existing code should've thrown an error from trying to call undefined method
CharsetMatch.first(), so this portion of the code is probably not covered by unit tests. It wouldn't be easy to write a test for this since this part of the code is only reached if the first encoding detector fails.