Remove unnecessary cast() in data.py #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junholee6a
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
auto-merge was automatically disabled
April 26, 2023 23:43
Head branch was pushed to by a user without write access
junholee6a
force-pushed
the
remove-cast-3
branch
from
1beb221 to
2b06bb4
Compare
|
@junholee6a update branch on this one next. We'll do this for #801 next. Thx! |
auto-merge was automatically disabled
April 27, 2023 15:00
Head branch was pushed to by a user without write access
junholee6a
force-pushed
the
remove-cast-3
branch
from
2b06bb4 to
3460bb5
Compare
|
okay ready to go on these, @junholee6a -- update branch and I'll approve and set to auto merge |
Simply assigning dict() to options changes its type from Union[builtins.dict[Any, Any], None] to builtins.dict[Any, Any]
junholee6a
force-pushed
the
remove-cast-3
branch
from
3460bb5 to
6550bf6
Compare
JGSweets
approved these changes
Apr 27, 2023
ksneab7
approved these changes
Apr 27, 2023
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #717
Removing this
cast()doesn't cause a mypy error.Simply assigning
dict()tooptionschanges its type fromUnion[builtins.dict[Any, Any], None]tobuiltins.dict[Any, Any]. So casting doesn't do anything here.