Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the location where the ruby is missing #74

Merged

Conversation

creitve
Copy link
Contributor

@creitve creitve commented Sep 27, 2017

For the Issue #73

@capistrano-bot
Copy link

capistrano-bot commented Sep 27, 2017

Thanks for the PR! This project lacks automated tests, which makes reviewing and approving PRs somewhat difficult. Please make sure that your contribution has not broken backwards compatibility or introduced any risky changes.

Generated by 🚫 Danger

@creitve
Copy link
Contributor Author

creitve commented Sep 27, 2017

Also please tell me if you do want to see the changelog updated with this^

@mattbrictson
Copy link
Member

Hi, thanks for creating this PR! Yes, I think a CHANGELOG entry is warranted here.

Also, I think the warning could be improved even further by including the host name. The host is passed to every on block, so you can do it like this:

# Notice the additional `host` argument
on release_roles(fetch(:rbenv_roles)) do |host|
  # ...
  warn "rbenv: #{rbenv_ruby} is not installed or not found in #{fetch(:rbenv_ruby_dir)} on #{host}"

@creitve
Copy link
Contributor Author

creitve commented Sep 27, 2017

Thanks for your help! I hope that this will suffice.

@mattbrictson
Copy link
Member

Looks good, thanks! 🙇

@mattbrictson mattbrictson merged commit 8e329d2 into capistrano:master Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants