Make rbenv_ruby optional #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems reasonable to me, but I don't use |
|
It would be great to see this merged. Is there anything I could do to increase it's chances of getting merged? |
|
@kirs @leehambley Any strong opinions on this one? |
|
+1 for me - I'd like the app server to decide which ruby version to use, and when the app server upgrades its ruby version, why do I have to update every deploy config of every single app? So having this optional - forcing a ruby version if I really want/need to, otherwise simply using the global ruby version - seems to be a good way to make everybody happy. |
|
OK, I'll merge this in. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #61 and resolves the issue where the Ruby version changes between the current and new releases.
By removing the requirement for
:rbenv_ruby, we can delegate the decision to the remote host'srbenv, which will follow these steps to choose a version. This mitigates the above problem by using the 'old' Ruby version to run commands oncurrent, and the 'new' Ruby version on the release in progress.