Add migration_command accessor for overriding #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With rails 6 multiple database support the `db:migrate` command isn't always what is needed when deploying to an environment. Other usecases are only running migrations for one of the databases using something like `db:migrate:primary`. Exposing the accessor `migration_command` allows flexibility for more scenarios.
|
Thanks for the PR! This project lacks automated tests, which makes reviewing and approving PRs somewhat difficult. Please make sure that your contribution has not broken backwards compatibility or introduced any risky changes. Generated by 🚫 Danger |
|
👍 |
|
Nice, thanks for the well documented PR! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exposing the accessor
migration_commandallows more flexibility in running migrations.With rails 6 multiple database support the
db:migratecommand isn't always what is needed when deploying to an environment.Other usecases can include only running migrations for one of the databases, using something like
db:migrate:primary.Short checklist
Other Information
Our app only has access to migrate one of the databases the rails application connects to, so currently we get an error when trying to deploy without this change.
A side note, locally when I run the deployment but pointing to our fork of this gem I need to use
bundle exec capinstead of justcap, just incase anybody else tries using the fork.Thanks for the great library! ❤️ Let me know if you need any changes.