Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @capacitor-mlkit/selfie-segmentation package #68

Merged
merged 5 commits into from
Sep 3, 2023
Merged

feat: add @capacitor-mlkit/selfie-segmentation package #68

merged 5 commits into from
Sep 3, 2023

Conversation

trancee
Copy link
Contributor

@trancee trancee commented Sep 2, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).

@robingenz
Copy link
Member

Do you want me to review it?

@trancee
Copy link
Contributor Author

trancee commented Sep 2, 2023

Do you want me to review it?

Yes, at least the Android implementation so far.

I was wondering if it is that helpful to return the segmentation mask as number array, and instead give an option to already apply this to the input image and return an output image as well?

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only two small things.

@robingenz
Copy link
Member

Do you want me to review it?

Yes, at least the Android implementation so far.

I was wondering if it is that helpful to return the segmentation mask as number array, and instead give an option to already apply this to the input image and return an output image as well?

@trancee Would you add a confidence option as a threshold and depending on that create the image or what do you have in mind?
But it looks good to me as it is for now.

@trancee
Copy link
Contributor Author

trancee commented Sep 2, 2023

@trancee Would you add a confidence option as a threshold and depending on that create the image or what do you have in mind? But it looks good to me as it is for now.

I am actually not sure yet. But I will keep it as is for now and maybe add something later if it is difficult to use in JavaScript.

@trancee trancee requested a review from robingenz September 2, 2023 18:57
@robingenz robingenz merged commit 1b3f632 into capawesome-team:feat/selfie-segmentation Sep 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants