-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add @capacitor-mlkit/selfie-segmentation package #68
feat: add @capacitor-mlkit/selfie-segmentation package #68
Conversation
Do you want me to review it? |
Yes, at least the Android implementation so far. I was wondering if it is that helpful to return the segmentation mask as number array, and instead give an option to already apply this to the input image and return an output image as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only two small things.
...ava/io/capawesome/capacitorjs/plugins/mlkit/selfiesegmentation/SelfieSegmentationPlugin.java
Show resolved
Hide resolved
@trancee Would you add a |
I am actually not sure yet. But I will keep it as is for now and maybe add something later if it is difficult to use in JavaScript. |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset
).