Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass through GetIdTokenOptions to firebase web currentUser.getId… #84

Merged
merged 1 commit into from
May 16, 2022
Merged

fix: pass through GetIdTokenOptions to firebase web currentUser.getId… #84

merged 1 commit into from
May 16, 2022

Conversation

meds
Copy link
Contributor

@meds meds commented May 15, 2022

…Token

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).

@robingenz robingenz added bug/fix Something isn't working platform: web Web platform package: authentication labels May 15, 2022
robingenz
robingenz approved these changes May 15, 2022
View reviewed changes
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@robingenz
Copy link
Member

Please run npm run fmt and push the changes.

@meds meds force-pushed the fix/pass-getidtokenoptions branch from 99d7fcc to 9731ac0 Compare May 16, 2022 10:31
@meds
Copy link
Contributor Author

meds commented May 16, 2022

Please run npm run fmt and push the changes.

done 👍

@robingenz robingenz merged commit 935744d into capawesome-team:main May 16, 2022
@github-actions github-actions bot mentioned this pull request May 16, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robingenz robingenz robingenz approved these changes

Assignees
No one assigned
Labels
bug/fix Something isn't working package: authentication platform: web Web platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meds @robingenz