-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set correct path for SPM packages #801
Conversation
@alexookah Why is this not required for the official plugins? For example: https://github.com/ionic-team/capacitor-plugins/blob/6f5a8efa5ed48f6ca17ac189757335d57c6f8e66/camera/Package.swift#L22 I think there must be another solution. |
The path depends of where the plugin exists. if you see the official plugin has different folder structure. But your folder structure in all packages are: |
@alexookah Yes, I've just seen it. Sorry! 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 💪
@capacitor-firebase/analytics
@capacitor-firebase/app
@capacitor-firebase/app-check
@capacitor-firebase/authentication
@capacitor-firebase/crashlytics
@capacitor-firebase/firestore
@capacitor-firebase/functions
@capacitor-firebase/messaging
@capacitor-firebase/performance
@capacitor-firebase/remote-config
@capacitor-firebase/storage
commit: |
@robingenz |
The next version will be a major release. I'm therefore waiting for the release of Capacitor 7 which should happen in the near future since the first RC is already published. However, you can just use our pre-releases. |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset
).