Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct path for SPM packages #801

Merged
merged 3 commits into from
Jan 18, 2025

Conversation

alexookah
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

@alexookah alexookah mentioned this pull request Jan 18, 2025
@robingenz
Copy link
Member

@alexookah Why is this not required for the official plugins? For example: https://github.com/ionic-team/capacitor-plugins/blob/6f5a8efa5ed48f6ca17ac189757335d57c6f8e66/camera/Package.swift#L22 I think there must be another solution.

@alexookah
Copy link
Contributor Author

@alexookah Why is this not required for the official plugins? For example: https://github.com/ionic-team/capacitor-plugins/blob/6f5a8efa5ed48f6ca17ac189757335d57c6f8e66/camera/Package.swift#L22 I think there must be another solution.

The path depends of where the plugin exists. if you see the official plugin has different folder structure.
camera/ios/Sources/CameraPlugin

But your folder structure in all packages are:
*plugin*/ios/Plugin

@robingenz
Copy link
Member

@alexookah Yes, I've just seen it. Sorry! 😁

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💪

@robingenz robingenz changed the title Fix path for packages in SPM fix: set correct path for SPM packages Jan 18, 2025
Copy link

pkg-pr-new bot commented Jan 18, 2025

Open in Stackblitz

@capacitor-firebase/analytics

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/analytics@801

@capacitor-firebase/app

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app@801

@capacitor-firebase/app-check

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app-check@801

@capacitor-firebase/authentication

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/authentication@801

@capacitor-firebase/crashlytics

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/crashlytics@801

@capacitor-firebase/firestore

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/firestore@801

@capacitor-firebase/functions

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/functions@801

@capacitor-firebase/messaging

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/messaging@801

@capacitor-firebase/performance

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/performance@801

@capacitor-firebase/remote-config

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/remote-config@801

@capacitor-firebase/storage

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/storage@801

commit: 333bfd8

@robingenz robingenz merged commit b811519 into capawesome-team:main Jan 18, 2025
4 checks passed
@alexookah alexookah deleted the fix_spm_path branch January 18, 2025 15:09
@alexookah
Copy link
Contributor Author

@robingenz
When are you planning to create next version?

@robingenz
Copy link
Member

The next version will be a major release. I'm therefore waiting for the release of Capacitor 7 which should happen in the near future since the first RC is already published. However, you can just use our pre-releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants