-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(authentication): explicitly request Google auth token with provided scopes on Android #726
Conversation
@capacitor-firebase/analytics
@capacitor-firebase/app
@capacitor-firebase/app-check
@capacitor-firebase/authentication
@capacitor-firebase/crashlytics
@capacitor-firebase/firestore
@capacitor-firebase/functions
@capacitor-firebase/messaging
@capacitor-firebase/performance
@capacitor-firebase/remote-config
@capacitor-firebase/storage
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a private method List<String> getScopesAsList(@NonNull PluginCall call)
to reduce duplicate code.
@robingenz all set! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This PR explicitly requests scopes when getting a Google access token post-Sign In with Google.
It looks like not requesting scopes explicitly works most of the time, but not all of the time. I had two users with this bug (nkalupahana/baseline#402), and this change fixed it for them (patch). This PR upstreams our patch.
Closes #725
Pull request checklist
npm run changeset
).