-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authentication): add updateProfile
method
#277
Conversation
LGTM |
@robingenz I am trying to fix the path in the /// <reference types="@capacitor/firebase-authentication" /> This seems wrong as it should be /// <reference types="@capacitor-firebase/authentication" /> But fixing this directly in the |
@trancee This is an open issue which i already reported: ionic-team/capacitor-docgen#40 |
updateProfile
method
@robingenz I was wondering, when the |
You should call |
.../io/capawesome/capacitorjs/plugins/firebase/authentication/FirebaseAuthenticationPlugin.java
Outdated
Show resolved
Hide resolved
packages/authentication/ios/Plugin/FirebaseAuthenticationPlugin.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trancee Thank you for your contribution again!
* docs * feat(android): implement updateProfile * docs: add changeset * feat(ios): implement updateProfile * fix(review) * fix(review)
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset
).Close #28