Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authentication): retain authStateChangeEvent until consumed #186

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

robingenz
Copy link
Member

@robingenz robingenz commented Aug 22, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).

Close #140
Close #159

@robingenz robingenz self-assigned this Aug 22, 2022
@robingenz robingenz added this to the v1.1.0 milestone Aug 22, 2022
Copy link

@Guiditox Guiditox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on IOS + Cap4

@robingenz robingenz merged commit eeeecae into main Aug 28, 2022
@robingenz robingenz deleted the feat/issue-140 branch August 28, 2022 06:03
@github-actions github-actions bot mentioned this pull request Aug 28, 2022
@aaronksaunders
Copy link

How do we get this fix since 1.1 hasn’t been released yet? Also is does listener work same as in js ask? Thanks

@robingenz
Copy link
Member Author

See #140 (comment).
Not sure what you mean with your second question.

Paso pushed a commit to ice-cream-club/capacitor-firebase that referenced this pull request Apr 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Issue - How to Sign To Firebase JS SDK From Event Listener bug: authStateChange never fires.
3 participants