feat(authentication): support Email Link Authentication

[trancee]

Pull request checklist

Please check if your PR fulfills the following requirements:

• The changes have been tested successfully.
• A changeset has been created (npm run changeset).

Implements #36

[robingenz]

@trancee Thanks for your contribution! That's a lot of changes. I will not get to the review for a few days as i am currently updating all plugins to Capacitor 4. Until then, please revert all changes that are not absolutely necessary (e.g. package-lock.json, project.pbxproj).
Please also test your changes and tick this off in the PR description if done.

[trancee]

@trancee Thanks for your contribution! That's a lot of changes. I will not get to the review for a few days as i am currently updating all plugins to Capacitor 4. Until then, please revert all changes that are not absolutely necessary (e.g. package-lock.json, project.pbxproj). Please also test your changes and tick this off in the PR description if done.

Thanks for the feedback. I will try to revert the unnecessary changes.

By the way, there is also a linking/re-authentication part using the EmailAuthProvider. Is that something that should be implemented as well?
https://firebase.google.com/docs/auth/web/email-link-auth#linkingre-authentication_with_email_link

And I added these changes for version 0.6.0 if that is alright with you (in the docs).

[robingenz]

Thank you! I will review it soon.

By the way, there is also a linking/re-authentication part using the EmailAuthProvider. Is that something that should be implemented as well?

No, this will be another PR in the future as this involves not only email sign in.

And I added these changes for version 0.6.0 if that is alright with you (in the docs).

This should be version 1.1.0 as the next release (Capacitor 4) will be 1.0.0.

[trancee]

No, this will be another PR in the future as this involves not only email sign in.

OK, that makes sense.

This should be version 1.1.0 as the next release (Capacitor 4) will be 1.0.0.

Should I change that already, or will you do this once you review the code?

[robingenz]

I will add a comment in my review.

[robingenz]

Thank you for your contribution! I will review again after your changes.

[trancee]

@robingenz I have added an additional step on how to enable app link functionality to directly open the link in the app. I hope it is clear enough.

[robingenz]

@trancee Looks very good! Next time should be the last review.
I run the CI, you may need to fix lint errors.

[trancee]

@trancee Looks very good! Next time should be the last review. I run the CI, you may need to fix lint errors.

The errors from the CI are like these:

Error: tor-firebase/authentication:lint: [error] No parser could be inferred for file: android/src/androidTest/java/com/getcapacitor/android/ExampleInstrumentedTest.java
Error: tor-firebase/authentication:lint: [error] No parser could be inferred for file: android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/authentication/FirebaseAuthentication.java
Error: tor-firebase/authentication:lint: [error] No parser could be inferred for file: android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/authentication/FirebaseAuthenticationConfig.java
Error: tor-firebase/authentication:lint: [error] No parser could be inferred for file: android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/authentication/FirebaseAuthenticationHelper.java
Error: tor-firebase/authentication:lint: [error] No parser could be inferred for file: android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/authentication/FirebaseAuthenticationPlugin.java
Error: tor-firebase/authentication:lint: [error] No parser could be inferred for file: android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/authentication/GetIdTokenResultCallback.java
Error: tor-firebase/authentication:lint: [error] No parser could be inferred for file: android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/authentication/handlers/AppleAuthProviderHandler.java
Error: tor-firebase/authentication:lint: [error] No parser could be inferred for file: android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/authentication/handlers/FacebookAuthProviderHandler.java
Error: tor-firebase/authentication:lint: [error] No parser could be inferred for file: android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/authentication/handlers/GoogleAuthProviderHandler.java
Error: tor-firebase/authentication:lint: [error] No parser could be inferred for file: android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/authentication/handlers/OAuthProviderHandler.java
Error: tor-firebase/authentication:lint: [error] No parser could be inferred for file: android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/authentication/handlers/PhoneAuthProviderHandler.java
Error: tor-firebase/authentication:lint: [error] No parser could be inferred for file: android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/authentication/handlers/PlayGamesAuthProviderHandler.java
Error: tor-firebase/authentication:lint: [error] No parser could be inferred for file: android/src/test/java/com/getcapacitor/ExampleUnitTest.java

But honestly, I have no idea what to do with that. Is there a configuration issue?

[robingenz]

But honestly, I have no idea what to do with that. Is there a configuration issue?

Are you using npm or pnpm etc.? (found this):

[robingenz]

LGTM! Only the CI (linting, etc.) is left.

[trancee]

But honestly, I have no idea what to do with that. Is there a configuration issue?

Are you using npm or pnpm etc.? (found this):

I am using only npm. But the CI is not using any of my local packages anyway, isn't it? I am looking at the issue you referenced to figure out what's going on.

[robingenz]

You're right. 😄 In the CI the error should not occur.

[robingenz]

The last lint errors:

@capacitor-firebase/authentication:lint: /Users/runner/work/capacitor-firebase/capacitor-firebase/packages/authentication/ios/Plugin/FirebaseAuthenticationPlugin.swift:151:62: error: Force Cast Violation: Force casts should be avoided. (force_cast)
@capacitor-firebase/authentication:lint: /Users/runner/work/capacitor-firebase/capacitor-firebase/packages/authentication/ios/Plugin/FirebaseAuthenticationPlugin.swift:158:63: error: Force Cast Violation: Force casts should be avoided. (force_cast)
@capacitor-firebase/authentication:lint: /Users/runner/work/capacitor-firebase/capacitor-firebase/packages/authentication/ios/Plugin/FirebaseAuthenticationPlugin.swift:163:40: error: Force Cast Violation: Force casts should be avoided. (force_cast)
@capacitor-firebase/authentication:lint: /Users/runner/work/capacitor-firebase/capacitor-firebase/packages/authentication/ios/Plugin/FirebaseAuthentication.swift:183:1: error: Line Length Violation: Line should be 200 characters or less: currently 228 characters (line_length)
@capacitor-firebase/authentication:lint: /Users/runner/work/capacitor-firebase/capacitor-firebase/packages/authentication/ios/Plugin/FirebaseAuthentication.swift:271:1: error: Line Length Violation: Line should be 200 characters or less: currently 242 characters (line_length)

[robingenz]

@trancee Thank you so much for your contribution. Great work!
This is the dev release you can already use:

npm i @capacitor-firebase/authentication@1.0.0-dev.077e999.1660304202

v1.1.0 will be published next week (see milestone).

[robingenz]

@trancee Btw: I think the twitter account in your GitHub profile is wrong or? One e too much? 😁 I would like to mention you on the release.

[trancee]

@trancee Btw: I think the twitter account in your GitHub profile is wrong or? One e too much? grin I would like to mention you on the release.

Oh, wow, I haven't noticed that for such a long time! Thanks for pointing that out to me, I have fixed it :)