Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend authentication to expose the idTokenChange event #710

Closed
3 of 13 tasks
cjhoward92 opened this issue Aug 29, 2024 · 1 comment · Fixed by #751
Closed
3 of 13 tasks

feat: extend authentication to expose the idTokenChange event #710

cjhoward92 opened this issue Aug 29, 2024 · 1 comment · Fixed by #751
Assignees
@ebarooni
Labels
feature Feature package: authentication

Comments

@cjhoward92
Copy link

cjhoward92 commented Aug 29, 2024 •
edited by robingenz
Loading

Plugin(s)

  • Analytics
  • App
  • App Check
  • Authentication
  • Crashlytics
  • Cloud Firestore
  • Cloud Functions
  • Cloud Messaging
  • Cloud Storage
  • Performance
  • Remote Config

Current problem

The idTokenChange event is not exposed. Also. on iOS, the auth change listener isn't correct. It should be like so https://firebase.google.com/docs/auth/ios/manage-users

Preferred solution

Do the things.

Alternative options

There are none - we need this.

Additional context

Before submitting
@cjhoward92 cjhoward92 mentioned this issue Aug 29, 2024
Closed
3 tasks
@robingenz
Copy link
Member

Also. on iOS, the auth change listener isn't correct.

What exactly is wrong with it? This listener is already used by many apps without any problems.

@robingenz robingenz changed the title feat: extend authentication to expose the idTokenChange event feat: extend authentication to expose the idTokenChange event Aug 29, 2024
ebarooni added a commit that referenced this issue Nov 4, 2024
@ebarooni
feat: extend authentication to support id token change event (#710)
383aef8 
* adds type definitions
ebarooni added a commit that referenced this issue Nov 4, 2024
@ebarooni
feat: extend authentication to support id token change event (#710)
7c731aa 
* implements idTokenChange on the web
ebarooni added a commit that referenced this issue Nov 4, 2024
@ebarooni
feat: extend authentication to support id token change event (#710)
edb122b 
* refactors handling id token change in separate method on the web
ebarooni added a commit that referenced this issue Nov 4, 2024
@ebarooni
feat: extend authentication to support id token change event (#710)
cd182a7 
* implements idTokenChange on ios
ebarooni added a commit that referenced this issue Nov 4, 2024
@ebarooni
feat: extend authentication to support id token change event (#710)
491d76a 
* implements idTokenChange on android
ebarooni added a commit that referenced this issue Nov 4, 2024
@ebarooni
feat: extend authentication to support id token change event (#710)
64440d4 
* ios pod install
ebarooni added a commit that referenced this issue Nov 6, 2024
@ebarooni
feat: extend authentication to support id token change event (#710)
c3915d5 
* replaces user with an object with token property
ebarooni added a commit that referenced this issue Nov 6, 2024
@ebarooni
feat: extend authentication to support id token change event (#710)
c22b878 
* removes IdTokenChange interface
ebarooni added a commit that referenced this issue Nov 6, 2024
@ebarooni
feat: extend authentication to support id token change event (#710)
43c1fe4 
* refactors handleIdTokenChange on the web
ebarooni added a commit that referenced this issue Nov 6, 2024
@ebarooni
feat: extend authentication to support id token change event (#710)
e66ca4d 
* refactors handleIdTokenChange on ios and android
ebarooni added a commit that referenced this issue Nov 6, 2024
@ebarooni
feat: extend authentication to support id token change event (#710)
13d3cb8 
* removes todos
ebarooni added a commit that referenced this issue Nov 6, 2024
@ebarooni
feat: extend authentication to support id token change event (#710)
48d49ac 
* adds changeset
@ebarooni ebarooni linked a pull request Nov 6, 2024 that will close this issue
Feat/extend authentication to support id token change #751
Merged
3 tasks
@robingenz robingenz mentioned this issue Nov 7, 2024
Merged
3 tasks
ebarooni added a commit that referenced this issue Nov 7, 2024
@ebarooni
feat: extend authentication to support id token change event (#710)
c7f90cf 
* implements suggested changes
robingenz added a commit that referenced this issue Nov 7, 2024
@ebarooni @robingenz
feat(authentication): add idTokenChange event listener (#751)
b57f1ee 
* feat: extend authentication to support id token change event (#710)

* adds type definitions

* feat: extend authentication to support id token change event (#710)

* implements idTokenChange on the web

* feat: extend authentication to support id token change event (#710)

* refactors handling id token change in separate method on the web

* feat: extend authentication to support id token change event (#710)

* implements idTokenChange on ios

* feat: extend authentication to support id token change event (#710)

* implements idTokenChange on android

* feat: extend authentication to support id token change event (#710)

* ios pod install

* feat: extend authentication to support id token change event (#710)

* replaces user with an object with token property

* feat: extend authentication to support id token change event (#710)

* removes IdTokenChange interface

* feat: extend authentication to support id token change event (#710)

* refactors handleIdTokenChange on the web

* feat: extend authentication to support id token change event (#710)

* refactors handleIdTokenChange on ios and android

* feat: extend authentication to support id token change event (#710)

* removes todos

* feat: extend authentication to support id token change event (#710)

* adds changeset

* Update .changeset/chilled-pumpkins-kick.md

* Update packages/authentication/src/definitions.ts

* Update packages/authentication/src/definitions.ts

* feat: extend authentication to support id token change event (#710)

* implements suggested changes

---------

Co-authored-by: Robin Genz <mail@robingenz.dev>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ebarooni ebarooni

Labels
feature Feature package: authentication
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/extend authentication to support id token change capawesome-team/capacitor-firebase
4 participants
@cjhoward92 @robingenz @ebarooni and others