fix(authentication): accessToken was returned as idToken (#58)

capawesome-team · Apr 2, 2022 · 243011c · 243011c
1 parent 5c0f381
commit 243011c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/poor-planets-wave.md b/.changeset/poor-planets-wave.md
@@ -0,0 +1,5 @@
+---
+"@capacitor-firebase/authentication": patch
+---
+
+fix: `accessToken` was returned as `idToken`
diff --git a/...enz/capacitorjs/plugins/firebase/authentication/handlers/FacebookAuthProviderHandler.java b/...enz/capacitorjs/plugins/firebase/authentication/handlers/FacebookAuthProviderHandler.java
@@ -71,7 +71,7 @@ private void handleSuccessCallback(LoginResult loginResult) {
         AccessToken accessToken = loginResult.getAccessToken();
         String accessTokenString = accessToken.getToken();
         AuthCredential credential = FacebookAuthProvider.getCredential(accessTokenString);
-        pluginImplementation.handleSuccessfulSignIn(savedCall, credential, accessTokenString, null, accessTokenString);
+        pluginImplementation.handleSuccessfulSignIn(savedCall, credential, null, null, accessTokenString);
     }
 
     private void handleCancelCallback() {

diff --git a/packages/authentication/ios/Plugin/Handlers/FacebookAuthProviderHandler.swift b/packages/authentication/ios/Plugin/Handlers/FacebookAuthProviderHandler.swift
@@ -36,7 +36,7 @@ class FacebookAuthProviderHandler: NSObject {
 
                 let accessTokenString = accessToken.tokenString
                 let credential = FacebookAuthProvider.credential(withAccessToken: accessTokenString)
-                self.pluginImplementation.handleSuccessfulSignIn(credential: credential, idToken: accessTokenString, nonce: nil, accessToken: accessTokenString)
+                self.pluginImplementation.handleSuccessfulSignIn(credential: credential, idToken: nil, nonce: nil, accessToken: accessTokenString)
             }
         }
         #endif