Stream removes itself upon destruction #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vqvu
reviewed
Mar 23, 2017
test/test.js
Outdated
| @@ -2864,6 +2864,16 @@ exports['wrap EventEmitter (or jQuery) on handler'] = function (test) { | |||
| }); | |||
| }; | |||
|
|
|||
| exports['removing EventEmitter (or jQuery) listener on destruction'] = function(test) { | |||
vqvu
reviewed
Mar 23, 2017
test/test.js
Outdated
| var ee = new EventEmitter(); | ||
| var s = _('myevent', ee); | ||
|
|
||
| test.same(typeof ee._events.myevent, 'function'); |
There was a problem hiding this comment.
Checking private state like _events is brittle. You should listen to the 'removeListener' event instead, and make sure that is is emitted when you destroy the stream.
vqvu
reviewed
Mar 23, 2017
lib/index.js
Outdated
| }; | ||
|
|
||
| secondArg.on(xs, callback_func); | ||
| var removeMethod = secondArg.removeListener || secondArg.unbind; |
There was a problem hiding this comment.
Can you add a comment that says which method belongs to which type of event emitters (EventEmitter or jQuery)?
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #500.