Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-339]: Images copied and pasted into KB article, do not save correctly. #550

Merged
merged 7 commits into from
Feb 21, 2024

Conversation

Orrison
Copy link
Collaborator

@Orrison Orrison commented Feb 20, 2024

Ticket(s) or GitHub Issue

Technical Description

Allows the copying/pasting or dragging/dropping of external images into the KB article editor. After an article is saved a job is then kicked off that will attempt to pull the image in to the apps filesystem. But it will leave it if it fails.


Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.

Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
@Orrison Orrison added Change Type | Bug Fix Something isn't working Change Type | New Feature New feature or request labels Feb 20, 2024
@Orrison Orrison requested a review from a team February 20, 2024 17:27
@Orrison Orrison self-assigned this Feb 20, 2024
Orrison and others added 2 commits February 20, 2024 17:29
Allow for passing in the other types of values the $content could be during Media processing

Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Orrison Orrison merged commit 60678cf into main Feb 21, 2024
7 checks passed
@Orrison Orrison deleted the feature/ADVAPP-339 branch February 21, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change Type | Bug Fix Something isn't working Change Type | New Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants