Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-327]: API Development for Authorization and Core Modules #545

Merged

Conversation

mxm1070
Copy link
Contributor

@mxm1070 mxm1070 commented Feb 16, 2024

Ticket(s) or GitHub Issue

Technical Description

Describe your changes in detail. This should include technical/architectural decisions and reasoning, if applicable.

Please ensure that at least one correct change type label is added to the PR. For example, if you are adding a new feature, please add the Change Type | New Feature label.

GraphQL for many models and related changes.

Screenshots (if appropriate)

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

If yes, please describe the deployment steps required below and apply the Deployment Steps label to the PR.


Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines:

…tion-core-modules

# Conflicts:
#	_ide_helper_models.php
#	app-modules/assistant/src/Providers/AssistantServiceProvider.php
#	app-modules/audit/src/Providers/AuditServiceProvider.php
#	app-modules/consent/src/Providers/ConsentServiceProvider.php
#	app-modules/student-data-model/src/Providers/StudentDataModelServiceProvider.php
@mxm1070 mxm1070 added the Change Type | New Feature New feature or request label Feb 16, 2024
@mxm1070 mxm1070 requested a review from a team February 16, 2024 22:36
@mxm1070 mxm1070 self-assigned this Feb 16, 2024
Copy link
Collaborator

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just left some some questions and notes

app-modules/assistant/graphql/assistant-chat.graphql Outdated Show resolved Hide resolved
app-modules/assistant/graphql/prompt.graphql Outdated Show resolved Hide resolved
app-modules/audit/graphql/audit.graphql Outdated Show resolved Hide resolved
app-modules/audit/graphql/audit.graphql Outdated Show resolved Hide resolved
app-modules/consent/graphql/consent-agreement.graphql Outdated Show resolved Hide resolved
app-modules/consent/graphql/user-consent-agreement.graphql Outdated Show resolved Hide resolved
app-modules/consent/src/GraphQL/Mutations/Consent.php Outdated Show resolved Hide resolved
app-modules/student-data-model/graphql/student.graphql Outdated Show resolved Hide resolved
app/GraphQL/Directives/MorphToRelationDirective.php Outdated Show resolved Hide resolved
@mxm1070 mxm1070 requested a review from Orrison February 19, 2024 20:27
Copy link

Quality Gate Passed Quality Gate passed

Issues
7 New issues

Measures
0 Security Hotspots
No data about Coverage
3.6% Duplication on New Code

See analysis details on SonarCloud

@Orrison Orrison merged commit 67d9560 into main Feb 19, 2024
7 checks passed
@Orrison Orrison deleted the feature/advapp-327-api-development-authorization-core-modules branch February 19, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change Type | New Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants