Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-311]: Improve the speed of permission / role loading (part 1) #532

Merged
merged 9 commits into from
Feb 15, 2024

Conversation

dgoetzit
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

This PR modifies the role/permission registration to remove unnecessary file interaction during application service provider booting. This PR will not have an impact on the speed of the role/permission seeding, but utilizes a better convention for registering roles and permissions with the application, and should have a minor impact on application performance overall (although challenging to observe with Octane).

Types of changes

  • New feature (non-breaking change which adds functionality)

Screenshots (if appropriate)

Any deployment steps required?

  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream main branch.

@dgoetzit dgoetzit self-assigned this Feb 14, 2024
@dgoetzit dgoetzit requested a review from a team February 14, 2024 20:16
@dgoetzit dgoetzit requested a review from Orrison February 15, 2024 16:30
Copy link
Collaborator

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a merge conflict

# Conflicts:
#	app-modules/service-management/src/Providers/ServiceManagementServiceProvider.php
@dgoetzit dgoetzit requested a review from Orrison February 15, 2024 18:59
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Orrison Orrison merged commit 1bbfebe into main Feb 15, 2024
7 checks passed
@Orrison Orrison deleted the feature/ADVAPP-311-role-permission-speed branch February 15, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants