-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADVAPP-309]: Link protection enhancement for realtime chat #526
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question about the UX of a detected javascript
href
link.
Also, there is a security flag in SonarCloud for that line as well. I believe based on the context that is a false flag. If you agree feel free to review the items in SonarCloud once logged in and mark it as "Safe" with a comment explaining why. I assume because it is not actually a javascript:
link like it is falsly detecting, but a pattern detecting one.
app-modules/in-app-communication/resources/js/TipTap/Extentions/SafeLink.js
Show resolved
Hide resolved
@danharrin since you are most familiar with TipTap plugins, if you wouldn't mind giving this a review as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great implementation!
Ticket(s) or GitHub Issue
Technical Description
This PR adds "link protection" in Realtime chat via a new SafeLink extension.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Screenshots (if appropriate)
Any deployment steps required?
Before contributing and submitting this PR, make sure you have:
main
branch.