Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-320]: Presentation of forms and portals is failing in prod. #517

Merged
merged 9 commits into from
Feb 12, 2024

Conversation

Orrison
Copy link
Collaborator

@Orrison Orrison commented Feb 9, 2024

Ticket(s) or GitHub Issue

Technical Description

Fixes issues with Production portal and widget loading. Switch to only do relative signed URLs. Which will give us the same parameters protection we wanted without dealing with the LB redirect issues.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Content or styling update (Changes which don't affect functionality)
  • DevOps
  • Documentation

Screenshots (if appropriate)

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • Yes, please specify
  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream main branch.

Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
@Orrison Orrison requested a review from a team February 9, 2024 19:16
@Orrison Orrison self-assigned this Feb 9, 2024
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
13.2% Duplication on New Code

See analysis details on SonarCloud

@Orrison Orrison merged commit d2157a4 into main Feb 12, 2024
7 checks passed
@Orrison Orrison deleted the feature/ADVAPP-320-fix-forms-and-portals branch February 12, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants