Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-253]: EditInteractionTest.php fails when a ServiceRequest is used #483

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

dgoetzit
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

This PR fixes a query scoping issue that was resulting in a test intermittently failing when a ServiceRequest was picked at random as the interactable type of an Interaction.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Screenshots (if appropriate)

Any deployment steps required?

  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

@dgoetzit dgoetzit self-assigned this Jan 31, 2024
@dgoetzit dgoetzit requested a review from a team January 31, 2024 01:26
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Orrison Orrison merged commit 8066dd8 into main Jan 31, 2024
7 checks passed
@Orrison Orrison deleted the bugfix/ADVAPP-253-failing-test branch January 31, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants