Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-259]: Containerize Advising App #482

Merged
merged 36 commits into from
Feb 1, 2024

Conversation

Orrison
Copy link
Collaborator

@Orrison Orrison commented Jan 30, 2024

Ticket(s) or GitHub Issue

Technical Description

Sets up the process for containerizing the application. In doing so we have switch from Laravel Sail to Spin.

You will want to run sail down -v on main before then switching to this branch. Then details on how it all works now are in the local development documentation.
It is mostly the same as Sail.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Content or styling update (Changes which don't affect functionality)
  • DevOps
  • Documentation

Screenshots (if appropriate)

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • Yes, please specify
  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

@Orrison Orrison self-assigned this Jan 30, 2024
mxm1070
mxm1070 previously approved these changes Feb 1, 2024
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Orrison and others added 11 commits February 1, 2024 11:56
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
dgoetzit
dgoetzit previously approved these changes Feb 1, 2024
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Orrison Orrison merged commit 80579c3 into main Feb 1, 2024
7 checks passed
@Orrison Orrison deleted the feature/ADVAPP-259-containerize branch February 1, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants