Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-239]: Correct issue for event creation when form is empty #475

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

mxm1070
Copy link
Contributor

@mxm1070 mxm1070 commented Jan 26, 2024

Ticket(s) or GitHub Issue

Technical Description

Fix creating events (and all the other forms) without form fields.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)

Screenshots (if appropriate)

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

@mxm1070 mxm1070 requested a review from Orrison January 26, 2024 18:09
@mxm1070 mxm1070 self-assigned this Jan 26, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
37.0% Duplication on New Code

See analysis details on SonarCloud

@Orrison Orrison merged commit eec7619 into main Jan 29, 2024
7 checks passed
@Orrison Orrison deleted the fix/advapp-239-correct-issue-event-creation-form-empty branch January 29, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants