Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-256] && [ADVAPP-257] #472

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Conversation

dgoetzit
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

This PR introduces support to show service request form submissions on student, prospect, and service request views.

Types of changes

  • New feature (non-breaking change which adds functionality)

Screenshots (if appropriate)

Any deployment steps required?

  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

@dgoetzit dgoetzit requested a review from a team January 25, 2024 18:36
@dgoetzit dgoetzit self-assigned this Jan 25, 2024
Copy link
Collaborator

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint and tests are currently failing

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
8.1% Duplication on New Code

See analysis details on SonarCloud

Orrison
Orrison previously approved these changes Jan 25, 2024
Base automatically changed from feature/ADVAPP-255-embed-service-form to main January 25, 2024 21:28
@Orrison Orrison dismissed their stale review January 25, 2024 21:28

The base branch was changed.

@Orrison Orrison merged commit b9ae401 into main Jan 25, 2024
7 checks passed
@Orrison Orrison deleted the feature/ADVAPP-257-submission-details branch January 25, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants