Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-244]: Introduce configuration of successful submission message for forms. #469

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

Orrison
Copy link
Collaborator

@Orrison Orrison commented Jan 24, 2024

Ticket(s) or GitHub Issue

Technical Description

Adds a configurable successfully submission message to forms and outputs it on the Form submitted. Markdown formatted.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Content or styling update (Changes which don't affect functionality)
  • DevOps
  • Documentation

Screenshots (if appropriate)

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • Yes, please specify
  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
Signed-off-by: Kevin Ullyott <kevin@kirschbaumdevelopment.com>
@Orrison Orrison requested a review from a team January 24, 2024 21:21
@Orrison Orrison self-assigned this Jan 24, 2024
Copy link

sonarqubecloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.1% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@mxm1070 mxm1070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Orrison Orrison merged commit da87ecf into main Jan 25, 2024
7 checks passed
@Orrison Orrison deleted the feature/ADVAPP-244-configurable-form-success-message branch January 25, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants