Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-227]: Introduce Channels for Realtime Chat #458

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Conversation

danharrin
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

Thanks to an excellent foundation, I was able to implement this with minimal changes to the existing system. However, I made a few cleanups and improvements where I noticed things.

I also updated the message UI to fix some sizing and show the author name and message time. This is not visible in the screen recording as it was implemented after:

Screenshot 2024-01-18 at 19 42 22

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Content or styling update (Changes which don't affect functionality)
  • DevOps
  • Documentation

Screenshots (if appropriate)

Screen.Recording.2024-01-18.at.18.48.03.mp4

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • Yes, please specify
  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

@danharrin danharrin requested a review from a team January 18, 2024 19:49
@danharrin danharrin self-assigned this Jan 18, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
9.2% Duplication on New Code

See analysis details on SonarCloud

@Orrison Orrison merged commit da54428 into main Jan 18, 2024
7 checks passed
@Orrison Orrison deleted the advapp-227 branch January 18, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants