Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/quality of life changes #437

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Conversation

Orrison
Copy link
Collaborator

@Orrison Orrison commented Jan 11, 2024

No description provided.

Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
@Orrison Orrison requested a review from danharrin January 11, 2024 16:48
@Orrison Orrison self-assigned this Jan 11, 2024
@mxm1070
Copy link
Contributor

mxm1070 commented Jan 11, 2024

If we're not going to do the Google cleanup anymore then maybe also remove

"extra": {
        ...,
        "google/apiclient-services": [
            "Oauth2",
            "Calendar"
        ]
    },

because it won't actually do anything now.

@Orrison
Copy link
Collaborator Author

Orrison commented Jan 11, 2024

If we're not going to do the Google cleanup anymore then maybe also remove

"extra": {
        ...,
        "google/apiclient-services": [
            "Oauth2",
            "Calendar"
        ]
    },

because it won't actually do anything now.

We are going to run the cleanup in deployment so I think these still need to be there.

@Orrison Orrison merged commit 2646482 into main Jan 11, 2024
6 checks passed
@Orrison Orrison deleted the feature/quality-of-life-changes branch January 11, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants