Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-32] & [ADVAPP-35] Ensure handling of invalid refresh_token for Outlook and Google #435

Merged
merged 11 commits into from
Jan 11, 2024

Conversation

Orrison
Copy link
Collaborator

@Orrison Orrison commented Jan 11, 2024

Ticket(s) or GitHub Issue

Technical Description

If the refresh token fails to renew the access token by being invalid we inform the User and give them a flow to reconnect.

We will now also refresh refresh_tokens to make sure they are never stale.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Content or styling update (Changes which don't affect functionality)
  • DevOps
  • Documentation

Screenshots (if appropriate)

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • Yes, please specify
  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
…weeks

Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
@Orrison Orrison requested a review from a team January 11, 2024 01:24
@Orrison Orrison self-assigned this Jan 11, 2024
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
@Orrison Orrison requested a review from danharrin January 11, 2024 14:17
danharrin
danharrin previously approved these changes Jan 11, 2024
@Orrison Orrison merged commit 403703c into main Jan 11, 2024
6 checks passed
@Orrison Orrison deleted the feature/ADVAPP-35-and-ADVAPP-32-refresh_token-renewal branch January 11, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants