-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADVAPP-32] & [ADVAPP-35] Ensure handling of invalid refresh_token for Outlook and Google #435
Merged
Orrison
merged 11 commits into
main
from
feature/ADVAPP-35-and-ADVAPP-32-refresh_token-renewal
Jan 11, 2024
Merged
[ADVAPP-32] & [ADVAPP-35] Ensure handling of invalid refresh_token for Outlook and Google #435
Orrison
merged 11 commits into
main
from
feature/ADVAPP-35-and-ADVAPP-32-refresh_token-renewal
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
…weeks Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
danharrin
requested changes
Jan 11, 2024
app-modules/meeting-center/resources/views/filament/components/calendar-setup-modal.blade.php
Outdated
Show resolved
Hide resolved
app-modules/notification/src/Notifications/EmailNotification.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
danharrin
previously approved these changes
Jan 11, 2024
danharrin
approved these changes
Jan 11, 2024
Orrison
deleted the
feature/ADVAPP-35-and-ADVAPP-32-refresh_token-renewal
branch
January 11, 2024 17:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) or GitHub Issue
Technical Description
If the refresh token fails to renew the access token by being invalid we inform the User and give them a flow to reconnect.
We will now also refresh refresh_tokens to make sure they are never stale.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Screenshots (if appropriate)
Any deployment steps required?
A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.
Before contributing and submitting this PR, make sure you have:
develop
branch.