-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADVAPP-185] & [ADVAPP-186]: Enforce license relationship for Retention CRM with respect to students / prospects #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-level' into advapp-185-186
Orrison
requested changes
Jan 4, 2024
...modules/caseload-management/src/Filament/Resources/CaseloadResource/Pages/CreateCaseload.php
Outdated
Show resolved
Hide resolved
app-modules/caseload-management/src/Policies/CaseloadPolicy.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/src/Models/Concerns/BelongsToEducatable.php
Show resolved
Hide resolved
Orrison
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) or GitHub Issue
Technical Description
License checking is mainly done in policies and scopes, but there are some exceptions when business logic comes into play.
The test suite has not been adapted for this changes yet. The tests have not been updated. However, since this is a large PR, it might be good to start reviewing, and then just don't merge until those are passing later today.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Screenshots (if appropriate)
Any deployment steps required?
A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.
All users must have licenses. This has been added to the super admin seeder.
Before contributing and submitting this PR, make sure you have:
develop
branch.