Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-185] & [ADVAPP-186]: Enforce license relationship for Retention CRM with respect to students / prospects #415

Merged
merged 21 commits into from
Jan 4, 2024

Conversation

danharrin
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

License checking is mainly done in policies and scopes, but there are some exceptions when business logic comes into play.

The test suite has not been adapted for this changes yet. The tests have not been updated. However, since this is a large PR, it might be good to start reviewing, and then just don't merge until those are passing later today.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Content or styling update (Changes which don't affect functionality)
  • DevOps
  • Documentation

Screenshots (if appropriate)

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • Yes, please specify
  • No

All users must have licenses. This has been added to the super admin seeder.


Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

@danharrin danharrin requested a review from a team January 4, 2024 15:03
@danharrin danharrin requested a review from Orrison January 4, 2024 19:57
@Orrison Orrison merged commit faef579 into develop Jan 4, 2024
6 checks passed
@Orrison Orrison deleted the advapp-185-186 branch January 4, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants