Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-153]: Rename "student email address" in Forms, Surveys, and Admissions to "Filler email address" #398

Merged

Conversation

Orrison
Copy link
Collaborator

@Orrison Orrison commented Dec 22, 2023

Ticket(s) or GitHub Issue

Technical Description

Renames the EducatableEmailFormFieldBlock block label to "Filler email address

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Content or styling update (Changes which don't affect functionality)
  • DevOps
  • Documentation

Screenshots (if appropriate)

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • Yes, please specify
  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
@Orrison Orrison requested a review from a team December 22, 2023 20:10
@Orrison Orrison self-assigned this Dec 22, 2023
@danharrin
Copy link
Contributor

How about "respondent" instead of "filler"?

@Orrison
Copy link
Collaborator Author

Orrison commented Dec 26, 2023

How about "respondent" instead of "filler"?

This name change was requested by Product. Currently it is felt "filler" will be most easily understood by a User.

@Orrison Orrison merged commit f6442df into develop Dec 26, 2023
5 checks passed
@Orrison Orrison deleted the feature/ADVAPP-153-rename-student-email-address-block branch December 26, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants